Add support for NodeList in register/unregister/reactivate#67
Merged
Conversation
Deploying foresightjs with
|
| Latest commit: |
9869633
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d0c562c.foresightjs.pages.dev |
| Branch Preview URL: | https://support-nodelist.foresightjs.pages.dev |
Owner
Author
|
@jlukic is this what you were looking for? |
|
Yes looks great, thanks for the addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
For backwards compatibility its still called
elementeven though it now also acceptsNodeListNodeListsupport toelementinForesightManager.instance.register()NodeListsupport toelementinForesightManager.instance.unregister()NodeListsupport toelementinForesightManager.instance.reactivate()ForesightManager.instance.register()return type toForesightRegisterResult | ForesightRegisterResult[]based on ifelementis a singleelementor aNodeListcallbackinForesightManager.instance.register()now has aForesightElementDataparameter so you know whichelement'scallbackis being activated and howForesightCallbacktype since its now not empty