Skip to content
This repository was archived by the owner on Apr 30, 2025. It is now read-only.

Conversation

@soywiz
Copy link
Member

@soywiz soywiz commented Aug 25, 2017

Fixed #242 (support synchronized blocks & synchronized methods)

@soywiz soywiz requested review from a user and intrigus August 25, 2017 18:57
@intrigus
Copy link
Contributor

intrigus commented Aug 26, 2017

Will try to have a look at this today/tomorrow :)
What's wrong with appveyor btw? I can have a look into it, cause a failing build is ugly :)

@codecov
Copy link

codecov bot commented Aug 26, 2017

Codecov Report

Merging #264 into master will increase coverage by 0.03%.
The diff coverage is 65.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
+ Coverage     17.85%   17.89%   +0.03%     
  Complexity      388      388              
============================================
  Files           313      312       -1     
  Lines         20773    20765       -8     
  Branches       4502     4502              
============================================
+ Hits           3710     3715       +5     
+ Misses        16388    16374      -14     
- Partials        675      676       +1
Impacted Files Coverage Δ Complexity Δ
.../com/jtransc/ast/treeshaking/TemplateReferences.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...e/src/com/jtransc/ast/template/CommonTagHandler.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../src/com/jtransc/io/JTranscConsolePrintStream.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...sc-gen-haxe/src/com/jtransc/gen/haxe/HaxeTarget.kt 79.52% <100%> (+0.15%) 11 <0> (ø) ⬇️
...ransc-gen-cpp/src/com/jtransc/gen/cpp/CppTarget.kt 82.03% <93.1%> (-0.37%) 4 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4670454...bb9774b. Read the comment docs.

@soywiz soywiz changed the title Haxe-Cpp synchronized blocks support + Thread improvements in all targets + Kotlin 1.1.4-2 Haxe-Cpp synchronized blocks & methods support + Thread improvements in all targets + Kotlin 1.1.4-2 Aug 26, 2017
@codecov-io
Copy link

codecov-io commented Aug 26, 2017

Codecov Report

Merging #264 into master will increase coverage by 0.03%.
The diff coverage is 33.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
+ Coverage     17.85%   17.89%   +0.03%     
  Complexity      388      388              
============================================
  Files           313      312       -1     
  Lines         20773    20749      -24     
  Branches       4502     4495       -7     
============================================
+ Hits           3710     3713       +3     
+ Misses        16388    16360      -28     
- Partials        675      676       +1
Impacted Files Coverage Δ Complexity Δ
.../com/jtransc/ast/treeshaking/TemplateReferences.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ransc-gen-as3/src/com/jtransc/gen/as3/As3Target.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...ransc-gen-php/src/com/jtransc/gen/php/PhpTarget.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
jtransc-gen-js/src/com/jtransc/gen/js/JsTarget.kt 87.36% <ø> (-0.41%) 4 <0> (ø)
...core/src/com/jtransc/gen/common/CommonGenerator.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ansc-gen-cs/src/com/jtransc/gen/cs/CSharpTarget.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/src/com/jtransc/ast/template/CommonTagHandler.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../src/com/jtransc/io/JTranscConsolePrintStream.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/src/com/jtransc/plugin/enum/EnumJTranscPlugin.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
jtransc-core/src/com/jtransc/ast/ast.kt 3.19% <0%> (+0.01%) 0 <0> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4670454...f6c97ab. Read the comment docs.

@soywiz
Copy link
Member Author

soywiz commented Aug 26, 2017

@intrigus it seems that cinst the chocolatey package manager for windows https://chocolatey.org/ fails installing haxe. But it is not a persistent issue. Maybe they have connection issues or something broke. Now it seems to be working. But maybe again it is temporal. Maybe we should try to cache chocolatey packages to minimize connection issues?

At any rate, I have created this repo: https://github.com/jtransc/jtransc-ci-experiments for doing experiments without having to create PRs. If you want to do experiments related to that, and once you have a good change, you can make a PR here.


In later commits I have implemented haxe synchronized methods. So now Haxe is on par with other targets. I implemented it with a try..catch surrounding the whole body + intercepting all return points, so I am not required to create additional methods.

I have also improved Thread API, simplifying it and supporting some other methods like join, or partial support for ThreadGroup.

@intrigus I have noticed that pure C++ target crashes when other threads are created. After some experiments, the culprit seems to be the GC. Not fixed (though uploaded some comments with the direction I tried, but not sure if it is compatible with C++11 threads; an investigation is required for this), just ignored thread test in C++ target explaining the reason.

@soywiz soywiz merged commit 3fa03ca into master Aug 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants