Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed listing slider issue #1555

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

syedgalib
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

  1. Create a listing with images.
  2. Visit the single listing page of the listing.
  3. Check if the slider images are shown or not.

Issue

Fixes

Checklist

@syedgalib syedgalib requested a review from vairafiq as a code owner August 8, 2023 05:37
@obiPlabon
Copy link
Collaborator

We don't need to escape predictable or fixed markup. So, instead of using wp_kses why don't we use inline escaping like the following:

printf( '<img class="plasmaSliderTempImgBlur" src="%s" alt="%s">', esc_url( $img_src ), esc_attr( $img_alt ) );
or
echo '<img class="plasmaSliderTempImgBlur" src="'.esc_url( $img_src ).'" alt="'.esc_attr( $img_alt ).'">';

Copy link
Collaborator

@obiPlabon obiPlabon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback shared

@vairafiq vairafiq added this to the v7.8.4 milestone Jan 23, 2024
@Armanul46 Armanul46 modified the milestones: v7.8.4, 7.8.5 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants