Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon optimization #1149

Merged
merged 336 commits into from
Aug 29, 2022
Merged

Icon optimization #1149

merged 336 commits into from
Aug 29, 2022

Conversation

kowsar89
Copy link
Contributor

No description provided.

devShamim and others added 30 commits February 22, 2022 12:28
@devShamim
JS/optimize: added masonry in all listings (#724)
7210b8a 
* Added all-lisitng.js file

* JS files splitted to individual page load

* commit changes

* Commit changes

* commit changes

* added search-form.js file

* Refactored class names in range-slider.js

* wpColorPicker js updated

* commit changes

* commit changes

* commit changes

* added masonry in all listings
@kowsar89
masonary
a830d8a
@kowsar89
masonary2
10109d4
@kowsar89
masonry2
3df6ecf
@kowsar89
masonry3
37de985
@kowsar89
color picker
b4776a2
@kowsar89
improved
83d80c7
@kowsar89
improved
e979166
@kowsar89
map
22e44cb
@kowsar89
improved
5844721
@devShamim
Js/optimize: OS map files refactor (#727)
60441b2
@kowsar89
Delete Helper.php
065f3aa
@kowsar89
Delete Scripts.php
b600acb
@kowsar89
js updated
9b62377
@kowsar89
improved
3f5df19
@devShamim
Js/optimize (#728)
9e89e6d
@kowsar89
Merge branch 'improve/asset2' of github.com:sovware/directorist into …
7f0bd8a 
…improve/asset2
@kowsar89
improved
55ea165
@kowsar89
map
6065df2
@kowsar89
improved
1a0c247
@kowsar89
improved
3aa24af
@kowsar89
improved
637c008
@kowsar89
improved
bd15951
@kowsar89
improved
51c0a07
@devShamim
JS/optimize: OpenStreet map data refactored in map-view (#729)
92a196e 
* Added all-lisitng.js file

* JS files splitted to individual page load

* commit changes

* Commit changes

* commit changes

* added search-form.js file

* Refactored class names in range-slider.js

* wpColorPicker js updated

* commit changes

* commit changes

* commit changes

* added masonry in all listings

* Commit changes

* commit changes

* commit changes

* Commit changes

* commit changes

* commit changes

* commit changes

* fixed drodpwn issue

* fixed drodpwn issue

* fixed drodpwn issue

* commit changes

* commit changes

* commit changes

* commit changes

* OS Map data refactored in map view
@kowsar89
script option
c1f0b80
@devShamim
JS/optimize (#730)
8bc5d9c
@kowsar89
gmap
4acb003
@kowsar89
cleanup
b3b7801
@devShamim
JS optimize: map files restructured (#732)
a17b0a9
@kowsar89 kowsar89 requested a review from vairafiq as a code owner August 25, 2022 10:45
@kowsar89
Copy link
Contributor Author

kowsar89 commented Aug 25, 2022 •
edited
Loading

Dev Notes

Filters removed:

  • atbdp_single_listing_tags_icon

Functions Deprecated:

  • atbdp_icon_type
  • atbdp_get_term_icon
  • get_fa_icons
  • get_fa_icons_full

Notes:

  • Fontawesome, lineawesome and unicon webfonts are not enqueued anymore in frontend.
  • Function directorist_icon() has been modified, now it renders svg icons. Instead of using <i class="fa fa-home"></i>, this function should be used everywhere for displaying icons.

@kowsar89 kowsar89 requested a review from syedgalib as a code owner August 29, 2022 03:15
vairafiq
vairafiq approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@vairafiq vairafiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass

@vairafiq vairafiq merged commit 5081dd4 into alpha Aug 29, 2022
@kowsar89 kowsar89 deleted the icon-optimize branch September 13, 2022 01:22
@kowsar89 kowsar89 restored the icon-optimize branch September 13, 2022 01:22
@obiPlabon obiPlabon deleted the icon-optimize branch June 13, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vairafiq vairafiq vairafiq approved these changes

@syedgalib syedgalib Awaiting requested review from syedgalib syedgalib is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kowsar89 @obiPlabon @vairafiq @devShamim @syedgalib