Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

实现了通过SauceNAO API和Imger API实现以图搜源 #19

Merged
20 commits merged into from
Oct 8, 2019
Merged

实现了通过SauceNAO API和Imger API实现以图搜源 #19

20 commits merged into from
Oct 8, 2019

Conversation

frg2089
Copy link
Contributor

@frg2089 frg2089 commented Oct 4, 2019

选择文件进行搜索并打开最相似的图片的详情页
需要自备SauceNAO API和Imger API(在应用设置或在源码中)

@ghost
Copy link

ghost commented Oct 4, 2019

感谢你花时间对本项目的贡献。但代码存在数个不符合整体设计的地方,请加以修正:

  • 字符串资源文件请使用MAT工具
  • 和API相关的部分请将代码整理至PixivCS仓库,以便于管理和分享;
  • 以图搜图功能不要放置在主页面上;
  • 请不要将版本需求提升至10.0.18362.0,因为Windows 10 v1903至今未全面推送。

再次感谢你的贡献。

@ghost ghost self-requested a review October 4, 2019 18:32
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 数个新页面的后退将产生异常;
  • 主页面右上角无需作出更改,请将以图搜图功能合并进搜索页面;
  • 以图搜图API请提交至PixivCS项目以便于管理;
  • 请不要直接编辑resw资源文件,请使用MAT工具来管理字符串资源;
  • 请暂时不要提升目标版本。

@frg2089
Copy link
Contributor Author

frg2089 commented Oct 5, 2019

那么...MAT工具应该怎么用....?

@ghost
Copy link

ghost commented Oct 5, 2019

那么...MAT工具应该怎么用....?

请参阅:https://docs.microsoft.com/en-us/windows/uwp/design/globalizing/use-mat

@@ -44,4 +44,6 @@
>*|資源添加|使用MAT工具添加字符串
>|||我云寫代碼成功了!可把我牛逼坏了(插会腰)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好可爱233333333

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=w=

@frg2089 frg2089 requested a review from a user October 8, 2019 11:09
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢你抽时间作出的优秀贡献。

@ghost ghost merged commit ecf5883 into sovetskyfish:master Oct 8, 2019
@ghost
Copy link

ghost commented Oct 8, 2019

@all-contributors please add @frg2089 for code

@allcontributors
Copy link
Contributor

@tobiichiamane

I've put up a pull request to add @frg2089! 🎉

@ghost
Copy link

ghost commented Oct 8, 2019

已经在readme中添加你为代码贡献者。可能会重新安排你所做的UI更改以更符合统一的设计风格。

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant