Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3948] Update dotnet samples to target .Net 8 - Skills samples #422

Closed
wants to merge 2 commits into from

Conversation

sw-joelmut
Copy link

@sw-joelmut sw-joelmut commented Jun 3, 2024

Addresses # 3948
#minor

Description

This PR updates the Skills samples to target .NET 8

Specific Changes

  • Updated the following samples to target .NET 8
    • 80.skills-simple-bot-to-bot
    • 81.skills-skilldialog
    • 82.skills-sso-cloudadapter
  • README files updated to target .NET 8
  • Fixed an issue with skills-sso-cloudadapter when obtaining the Skill ID from claims.

Testing

These images show the updated bots working as expected.
80.skills-simple-bot-to-bot
imagen
81.skills-skilldialog
imagen
82.skills-sso-cloudadapter
imagen

@sw-joelmut sw-joelmut changed the title [#3948] Update dotnet samples to target Net 8 - Skills samples [#3948] Update dotnet samples to target .Net 8 - Skills samples Jun 3, 2024
@sw-joelmut sw-joelmut force-pushed the southworks/update/net8-skills branch from fc27e29 to c52de80 Compare June 3, 2024 18:45
@JhontSouth
Copy link

The dotnet restore command is failing with 82.skills-sso-cloudadapter

@sw-joelmut
Copy link
Author

The dotnet restore command is failing with 82.skills-sso-cloudadapter

#423

@JhontSouth
Copy link

The dotnet restore command is failing with 82.skills-sso-cloudadapter

#423

I forgot it, continue

@sw-joelmut
Copy link
Author

/promoted 3983

@sw-joelmut sw-joelmut closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants