Cleanup foodcritic exceptions

[zarry]

Just an action item for myself. I will work on this. In no ways a blocker to the 2.2.1 release, but I expect to have it taken care of prior to release.

[lzarou@MAC-QA-LZ redisio (2.0.0_wip)]$ foodcritic .
FC002: Avoid string interpolation where not required: ./providers/configure.rb:71
FC002: Avoid string interpolation where not required: ./providers/sentinel.rb:76
FC002: Avoid string interpolation where not required: ./templates/default/redis.conf.erb:85
FC002: Avoid string interpolation where not required: ./templates/default/redis.conf.erb:91
FC002: Avoid string interpolation where not required: ./templates/default/sentinel.conf.erb:9
FC002: Avoid string interpolation where not required: ./templates/default/sentinel.conf.erb:11
FC017: LWRP does not notify when updated: ./providers/configure.rb:21
FC017: LWRP does not notify when updated: ./providers/install.rb:20
FC017: LWRP does not notify when updated: ./providers/sentinel.rb:20
FC019: Access node attributes in a consistent manner: ./recipes/_install_prereqs.rb:20
FC023: Prefer conditional attributes: ./providers/configure.rb:165
FC034: Unused template variables: templates/default/redis.conf.erb:1
FC034: Unused template variables: templates/default/redis.init.erb:1
FC034: Unused template variables: templates/default/redis.upstart.conf.erb:1
FC034: Unused template variables: templates/default/sentinel.conf.erb:1
FC034: Unused template variables: templates/default/sentinel.init.erb:1
FC034: Unused template variables: templates/default/sentinel.upstart.conf.erb:1
FC048: Prefer Mixlib::ShellOut: ./providers/configure.rb:100
FC048: Prefer Mixlib::ShellOut: ./providers/sentinel.rb:55

[zarry]

Fixed and pushed.

FC002: Avoid string interpolation where not required: ./providers/configure.rb:71
FC002: Avoid string interpolation where not required: ./providers/sentinel.rb:76
FC002: Avoid string interpolation where not required: ./templates/default/redis.conf.erb:85
FC002: Avoid string interpolation where not required: ./templates/default/redis.conf.erb:91
FC002: Avoid string interpolation where not required: ./templates/default/sentinel.conf.erb:9
FC002: Avoid string interpolation where not required: ./templates/default/sentinel.conf.erb:11
FC017: LWRP does not notify when updated: ./providers/configure.rb:21
FC017: LWRP does not notify when updated: ./providers/install.rb:20
FC017: LWRP does not notify when updated: ./providers/sentinel.rb:20
FC019: Access node attributes in a consistent manner: ./recipes/_install_prereqs.rb:20
FC023: Prefer conditional attributes: ./providers/configure.rb:165

The FC034: Unused template variables I am not overly worried about. The last few after that I will take a look at tomorrow.

[martinb3]

FWIW, I cleaned up a ton of rubocop stuff like that as well in #144.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.