Skip to content

filesystem setting within lvm logical volume needs to be a required field #162

Open

Description

Cookbook version

4.1.12

Chef-client version

14.3.37

Platform Details

Ubuntu 16.04

Scenario:

When you use lvm_logical_volume and filesystem is not set, it seems to send a nil string to the mount resource's using it's fstype parameter. This is a required field for the mount resource and can't be a blank string.

Steps to Reproduce:

Use lvm_logical_volume without setting 'filesystem'.

Expected Result:

I was expecting it to automatically pull the filesystem, which is what the mount resource will do if no value is set here. Erroring and letting us know this is a required field would be fine too.

Actual Result:

This is the entry it added when filesystem wasn't set -
/dev/mapper/location /opt/mount defaults 0 0

Because this field isn't set, the regex that checks to see if the fstab entry already exists fails as there are only 5 fields in the entry - https://github.com/chef/chef/blob/master/lib/chef/provider/mount/mount.rb#L64

It will then add multiple duplicate entries, which will then cause the box to go into emergency mode when restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions