-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXP] explore alternative MinHash constructors, and other things. #1510
base: latest
Are you sure you want to change the base?
Conversation
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## add/immutable_minhash_countergather #1510 +/- ##
=======================================================================
- Coverage 95.22% 95.15% -0.08%
=======================================================================
Files 99 99
Lines 17485 17537 +52
Branches 1590 1597 +7
=======================================================================
+ Hits 16650 16687 +37
- Misses 606 614 +8
- Partials 229 236 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
review #999 (comment) |
PR into #1508 for the moment, building off of
FrozenMinHash
work. It's not clear how much of this has to wait for v5, but I think we can do a lot with new constructors and not necessarily breaking or removing old ones.In brief, add new
MinHash
constructors (at the Python level) forNumMinHash
andScaledMinHash
__init__
MinHash initialization #338Explore other ideas -
add_sequence
changes add_sequence method for MinHash #186num
behavior update 'num' behavior, in terms of downsampling and comparison checking #870is_
functions update MinHash attributes/properties for consistency, and/or switch to using moltype attribute #1136