Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXP] explore alternative MinHash constructors, and other things. #1510

Open
wants to merge 270 commits into
base: latest
Choose a base branch
from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented May 10, 2021

PR into #1508 for the moment, building off of FrozenMinHash work. It's not clear how much of this has to wait for v5, but I think we can do a lot with new constructors and not necessarily breaking or removing old ones.

In brief, add new MinHash constructors (at the Python level) for NumMinHash and ScaledMinHash

Explore other ideas -

ctb and others added 27 commits May 5, 2021 10:06
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1510 (0426915) into add/immutable_minhash_countergather (8457daf) will decrease coverage by 0.07%.
The diff coverage is 71.15%.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           add/immutable_minhash_countergather    #1510      +/-   ##
=======================================================================
- Coverage                                95.22%   95.15%   -0.08%     
=======================================================================
  Files                                       99       99              
  Lines                                    17485    17537      +52     
  Branches                                  1590     1597       +7     
=======================================================================
+ Hits                                     16650    16687      +37     
- Misses                                     606      614       +8     
- Partials                                   229      236       +7     
Flag Coverage Δ
python 95.15% <71.15%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/minhash.py 86.91% <46.42%> (-3.01%) ⬇️
tests/test_minhash.py 99.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8457daf...0426915. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented May 15, 2021

review #999 (comment)

Base automatically changed from add/immutable_minhash_countergather to latest May 15, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants