Skip to content

Add Github Actions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 28, 2022
Merged

Add Github Actions #1

merged 18 commits into from
Apr 28, 2022

Conversation

iBotPeaches
Copy link
Member

No description provided.

Copy link

@toadbane toadbane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looked fine to me, but there is a build error. Looks like there is a lot going on in it, so not sure.

@iBotPeaches
Copy link
Member Author

The code looked fine to me, but there is a build error. Looks like there is a lot going on in it, so not sure.

Yeah I was attempting to upstream a PR to this repo to help out, but it looks like building node dependencies has some issues so backlogged it.

@iBotPeaches iBotPeaches reopened this Apr 22, 2022
@iBotPeaches
Copy link
Member Author

Bringing this back.

@iBotPeaches
Copy link
Member Author

Okay, this is a lot of stuff. I basically started getting CI to work on Actions vs TravisCI. Saw Jest was like 4 years out of date, then updated that and syntax was failing new linter. So went crazy.

Stuck with 2 failing tests, unsure at present. @ian-wd - lets see if we can fix those and even remove the "anti-ci" checks, because GitHub CI I think is far superior to Travis so I believe it will work.

@iBotPeaches iBotPeaches merged commit 3710a7f into master Apr 28, 2022
@iBotPeaches iBotPeaches deleted the actions branch April 28, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants