fix: ensure we fallback in combined mode on iOS #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chase-patterson
previously approved these changes
Aug 2, 2023
iBotPeaches
force-pushed
the
only-on-success
branch
from
8034f86 to
3cb63e0
Compare
iBotPeaches
force-pushed
the
fix-corrupted-value
branch
from
2d8c915 to
5f0af95
Compare
jyann
previously approved these changes
Aug 3, 2023
iBotPeaches
force-pushed
the
only-on-success
branch
from
3cb63e0 to
62c09b8
Compare
iBotPeaches
dismissed stale reviews from jyann and chase-patterson
The base branch was changed.
- includes patch for IDScan malforming input
iBotPeaches
force-pushed
the
fix-corrupted-value
branch
from
5f0af95 to
1404d9e
Compare
chase-patterson
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that in a combined situation that if we go from PDF -> MRZ. MRZ will ALWAYS fail, because PDF corrupts our input.
This introduces a copy of the string so it can corrupt its own isolated string without affecting MRZ.