remove exit when failed count is more than 0 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
requested changes
May 21, 2025
There was a problem hiding this comment.
This would be a breaking change as this action for years has always quit when a single instance is marked as failed. So for this to go forward it would need to become a parameter that defaults to the existing behavior.
Could you also describe your use-case that you have a failed instance during deployment, but want to continue polling? I'm just not following why that would occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed instance is resulting in fail of the workflow.
The result of job should not be decided based on the failed count but on the codeDeploy status.
Hence removing the exit when failed instance count is over zero