Pull request on wrong preprocessor symbol for HAVE_INT128 #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING! Errorneous at the moment.
Fixed most issues. One still needs a patch to gfortran. Therefore the pde-solver might fail with an unpatched gfortran still.
…n program or the scope where array descriptors are stored may be already destroyed when accessed by other (slower) images. mpi_caf.c: Fixing sync_images, when a stopped image is slow to reach its caf_finalize and set the stopped status, while other images have read an ok status already and now wait on its send. Realized by using waitany and propagating a stopped image status. Small speed up in get_by_ref and smaller memory footprint. Still failing tests: hello_multiverse: This test fails in general with the gcc-7 fortran compiler, because the string is not composed correctly. This is independent of coarrays being present or not.
Current coverage is 37.37% (diff: 100%)@@ master #237 diff @@
==========================================
Files 2 2
Lines 907 907
Methods 42 42
Messages 0 0
Branches 195 195
==========================================
Hits 339 339
Misses 504 504
Partials 64 64
|
|
Superseded by #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes the issue the on certain systems the HAVE_INT_128T guard was available although the int128_t was not. The commit syncs the guard to be HAVE_GFC_INTEGER_16 and the type to be __int128 like it is used in previous code.