Skip to content

Conversation

@rouson
Copy link
Member

@rouson rouson commented May 18, 2016

This merge corrects several issues with handling the definition of build and install directory names and their creation and detection when previously created. It also eliminates an error message that occurs when there is no mpif90 present.

@zbeekman
Copy link
Collaborator

@rouson This looks good and is now passing! Further more, it seems that there is less output now and we may be able to safely remove the hack that was being used to prevent the build from erroring due to excessive output.

@rouson
Copy link
Member Author

rouson commented May 18, 2016

If there is less output, that's coincidental. I don't think I did anything to reduce the output and would be a little surprised if any change in the output is significant. I'll create an issue for me to go through all of the installation scripts and replace "echo" and "printf" with a bash3boilerplate output function wherever possible. Then we can vary the amount of output by setting the LOG_LEVEL.

@zbeekman
Copy link
Collaborator

I'm going to attempt to adjust the CI scripts to not background the install.sh script by pushing to this branch... if it doesn't work I'll revert the changes, but if it does I'll clean up, merge and release

@rouson
Copy link
Member Author

rouson commented May 19, 2016

Sounds good.

D

Sent from my iPhone

On May 18, 2016, at 5:21 PM, Izaak Beekman notifications@github.com wrote:

I'm going to attempt to adjust the CI scripts to not background the install.sh script by pushing to this branch... if it doesn't work I'll revert the changes, but if it does I'll clean up, merge and release


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@zbeekman
Copy link
Collaborator

zbeekman commented May 19, 2016

It seems linux builds using the install script too (even though it uses gcc 5.2)! (but OS X had trouble fetching cmake with curl... I suspect it's just a fluke, re-running test now) We should add a flag to run ctest when installing with the install script...

@zbeekman
Copy link
Collaborator

zbeekman commented May 19, 2016

LGTM

Approved with PullApprove

@zbeekman zbeekman force-pushed the fix-termination-when-no-mpif90 branch from acf685d to 711cce8 Compare May 19, 2016 02:44
@zbeekman
Copy link
Collaborator

zbeekman commented May 19, 2016

LGTM

Approved with PullApprove

@zbeekman zbeekman merged commit 5eca9ac into master May 19, 2016
@zbeekman zbeekman deleted the fix-termination-when-no-mpif90 branch May 19, 2016 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants