-
-
Notifications
You must be signed in to change notification settings - Fork 57
Closed
Labels
Description
With the aim of making OpenCoarrays viable for use with multiple compilers, please ensure that all code that hits the master branch is standard-conforming. An example of non-standard code is the "call abort()" appearing throughout the test suite, including but definitely not limited to the following locations:
- Line 26 of get_with_offset_1d.f90.
- Line 45 and other lines in get_array_test.f90.
- Line 173 and other lines in old_get_array_test.f90.
- Line 133 of sameloc.f90.
and many other locations. Presumably these only terminate a single image and should therefore be replaced with stop. Alternatively, if global termination is intended, they should be replaced with error stop.
If there is a compelling reason to include non-standard code in the repository, let's document it. I will submit a separate issue to help address the state of documentation in the tests.