Skip to content

Make onboarding optional, able to be ignored on desktop (take 2) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 39 commits into
base: base-sha/7356af556ad087587c6b9aa5947abe6a6798e994
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
9fa99ed
Remove unused `telemetryLoader`
franknoirot Apr 24, 2025
58757ad
Remove onboarding redirect behavior
franknoirot Apr 28, 2025
a613700
Allow subRoute to be passed to navigateToProject
franknoirot Apr 28, 2025
f061da2
Replace warning dialog routes with toasts
franknoirot Apr 29, 2025
808ea6e
Wire up new utilities and toasts to UI components
franknoirot Apr 29, 2025
855fe8d
Add home sidebar buttons for tutorial flow
franknoirot Apr 29, 2025
e6b869a
Rename menu item
franknoirot Apr 29, 2025
8180036
Add flex-1 so home-layout fills available space
franknoirot Apr 29, 2025
5376592
Remove onboarding avatar tests, they are becoming irrelevant
franknoirot Apr 29, 2025
4bbffd0
Consolidate onboarding tests to one longer one
franknoirot Apr 29, 2025
1237d38
Shorten warning toast button text
franknoirot Apr 29, 2025
dd05756
tsc, lint, and circular deps
franknoirot Apr 29, 2025
d782233
Update circular dep file
franknoirot Apr 29, 2025
c92fc25
Fix mistakes made in circular update tweaking
franknoirot Apr 29, 2025
f1fc230
One more dumb created circular dep
franknoirot Apr 29, 2025
a75155c
Update src/routes/Onboarding/utils.tsx
franknoirot Apr 29, 2025
3e6a81f
Fix narrow screen home layout breaking
franknoirot Apr 29, 2025
ffd6b3d
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot Apr 29, 2025
1a43bd6
fix: kevin, navigation routes fixed
nadr0 Apr 29, 2025
5196776
Merge branch 'franknoirot/adhoc/optional-onboarding' of github.com:Ki…
nadr0 Apr 29, 2025
fcbf6bd
fix: filename parsing is correct now for onboarding with the last fil…
nadr0 Apr 29, 2025
ed2e73f
Fix e2e test state checks that are diff on Linux
franknoirot Apr 29, 2025
98fbee7
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot Apr 29, 2025
9380469
Create onboarding project entirely through systemIOMachine
franknoirot Apr 30, 2025
1ee6342
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot Apr 30, 2025
803f48c
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot Apr 30, 2025
20edda2
Fix Windows path construction
franknoirot Apr 30, 2025
92f8fb1
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot May 1, 2025
4eda3eb
Make utility to verify a string is an onboarding value
franknoirot May 1, 2025
fec8a5a
Little biome formatting suggestion fix
franknoirot May 1, 2025
144d4d3
Units onboarding step was not using OnboardingButtons
franknoirot May 1, 2025
a6b0fc8
Add type checking of next and previous status, fix useNextClick
franknoirot May 1, 2025
2a623f9
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot May 1, 2025
dd40339
Thanks Graphite Diamond, I should use that new util
franknoirot May 1, 2025
4e25ae4
Remove TODO comment
franknoirot May 1, 2025
a36c3d4
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot May 1, 2025
d47d3c1
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot May 1, 2025
f070033
Fix botched merge because IS_PLAYWRIGHT moved or something
franknoirot May 1, 2025
1ee345a
Merge branch 'main' into franknoirot/adhoc/optional-onboarding
franknoirot May 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/playwright/fixtures/homePageFixture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export class HomePageFixture {
projectTextName!: Locator
sortByDateBtn!: Locator
sortByNameBtn!: Locator
tutorialBtn!: Locator

constructor(page: Page) {
this.page = page
Expand All @@ -43,6 +44,7 @@ export class HomePageFixture {

this.sortByDateBtn = this.page.getByTestId('home-sort-by-modified')
this.sortByNameBtn = this.page.getByTestId('home-sort-by-name')
this.tutorialBtn = this.page.getByTestId('home-tutorial-button')
}

private _serialiseSortBy = async (): Promise<
Expand Down
4 changes: 4 additions & 0 deletions e2e/playwright/fixtures/toolbarFixture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ type LengthUnitLabel = (typeof baseUnitLabels)[keyof typeof baseUnitLabels]
export class ToolbarFixture {
public page: Page

projectName!: Locator
fileName!: Locator
extrudeButton!: Locator
loftButton!: Locator
sweepButton!: Locator
Expand Down Expand Up @@ -53,6 +55,8 @@ export class ToolbarFixture {
constructor(page: Page) {
this.page = page

this.projectName = page.getByTestId('app-header-project-name')
this.fileName = page.getByTestId('app-header-file-name')
this.extrudeButton = page.getByTestId('extrude')
this.loftButton = page.getByTestId('loft')
this.sweepButton = page.getByTestId('sweep')
Expand Down
8 changes: 4 additions & 4 deletions e2e/playwright/native-file-menu.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ test.describe(
)
await expect(actual).toBeVisible()
})
test('Home.Help.Reset onboarding', async ({
test('Home.Help.Replay onboarding tutorial', async ({
tronApp,
cmdBar,
page,
Expand All @@ -464,7 +464,7 @@ test.describe(
await tronApp.electron.evaluate(async ({ app }) => {
if (!app || !app.applicationMenu) return false
const menu = app.applicationMenu.getMenuItemById(
'Help.Reset onboarding'
'Help.Replay onboarding tutorial'
)
if (!menu) {
return false
Expand Down Expand Up @@ -2339,7 +2339,7 @@ test.describe(
await scene.connectionEstablished()
await expect(toolbar.startSketchBtn).toBeVisible()
})
test('Modeling.Help.Reset onboarding', async ({
test('Modeling.Help.Replay onboarding tutorial', async ({
tronApp,
cmdBar,
page,
Expand All @@ -2358,7 +2358,7 @@ test.describe(
await tronApp.electron.evaluate(async ({ app }) => {
if (!app || !app.applicationMenu) fail()
const menu = app.applicationMenu.getMenuItemById(
'Help.Reset onboarding'
'Help.Replay onboarding tutorial'
)
if (!menu) fail()
menu.click()
Expand Down
Loading