Skip to content

Conversation

@chess-equality
Copy link
Contributor

@chess-equality chess-equality commented Jul 6, 2023

…ls-no-show' into bugfix/issue-1056/dark-mode-labels-no-show
@BFergerson
Copy link
Contributor

Is this draft or ready for review? Please mark accordingly

@chess-equality
Copy link
Contributor Author

chess-equality commented Jul 7, 2023

There is an error with detekt; I'm checking.

@chess-equality chess-equality force-pushed the bugfix/issue-1056/dark-mode-labels-no-show branch from 64ebec1 to e02741e Compare July 7, 2023 01:09
@chess-equality chess-equality force-pushed the bugfix/issue-1056/dark-mode-labels-no-show branch from e02741e to 86617cd Compare July 7, 2023 01:20
@chess-equality chess-equality marked this pull request as ready for review July 7, 2023 01:40
@chess-equality
Copy link
Contributor Author

Ready for review.

@BFergerson
Copy link
Contributor

There are visual differences between this and the original version:

Old New
Screenshot from 2023-07-07 20-53-44 Screenshot from 2023-07-07 20-50-34

The old look specifically takes colors from the dark theme to blend in better. There should be no visual differences between the old and new (at least for the dark mode).

@chess-equality
Copy link
Contributor Author

There are visual differences between this and the original version:

The old look specifically takes colors from the dark theme to blend in better. There should be no visual differences between the old and new (at least for the dark mode).

Fixed in latest commit.

image

@BFergerson
Copy link
Contributor

@chess-equality, you're still missing colors.

Check here:
Untitled

You may need to view it using the new UI:
image

@chess-equality
Copy link
Contributor Author

@chess-equality, you're still missing colors.

Check here:

You may need to view it using the new UI:

@BFergerson Is this ok?

image

@BFergerson
Copy link
Contributor

@chess-equality, looks right. I'll give it a full review tomorrow.

@BFergerson
Copy link
Contributor

BFergerson commented Jul 11, 2023

@chess-equality, actually wait it looks like you're still using the old UI. I'm more concerned about how it looks in the new UI.

@chess-equality
Copy link
Contributor Author

@BFergerson Here are more screenshots with the new UI.

Part 1 of 2: all dark / all light

image

image

image

image

image

image

@chess-equality
Copy link
Contributor Author

Part 2 of 2: mixed

image

image

image

image

image

image

@BFergerson
Copy link
Contributor

@chess-equality, still seeing visible differences.

Old:
image

New:
image

@chess-equality
Copy link
Contributor Author

@chess-equality, still seeing visible differences.

Fixed in latest commit.

@BFergerson
Copy link
Contributor

lgtm

@BFergerson BFergerson merged commit 51409b2 into sourceplusplus:master Jul 14, 2023
@chess-equality chess-equality deleted the bugfix/issue-1056/dark-mode-labels-no-show branch July 18, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In dark mode / theme, labels are not showing

2 participants