Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(i): Update codecov to v4 #2669

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #2668

Description

I noticed that someone on the codecov repo mentioned that v4 fixed their issue codecov/codecov-action#598 (comment). Trying it :)

@fredcarle fredcarle added the ci/build This is issue is about the build or CI system, and the administration of it. label Jun 3, 2024
@fredcarle fredcarle added this to the DefraDB v0.12 milestone Jun 3, 2024
@fredcarle fredcarle requested a review from a team June 3, 2024 14:17
@fredcarle fredcarle self-assigned this Jun 3, 2024
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully this improves things - thanks for looking in to it :)

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.21%. Comparing base (2aeddc1) to head (7afae35).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2669      +/-   ##
===========================================
+ Coverage    76.40%   78.21%   +1.81%     
===========================================
  Files          303      303              
  Lines        28212    22996    -5216     
===========================================
- Hits         21555    17986    -3569     
+ Misses        5299     3655    -1644     
+ Partials      1358     1355       -3     
Flag Coverage Δ
all-tests 78.21% <ø> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 274 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aeddc1...7afae35. Read the comment docs.

@fredcarle fredcarle merged commit 97cc96c into develop Jun 3, 2024
35 of 36 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/codecov-update-v4 branch June 3, 2024 14:40
@shahzadlone
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update codecov action to v4
3 participants