-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update dependencies #2044
Conversation
6c96e23
to
ebf354e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## develop #2044 +/- ##
===========================================
+ Coverage 73.78% 73.87% +0.09%
===========================================
Files 248 248
Lines 24801 24801
===========================================
+ Hits 18297 18320 +23
+ Misses 5237 5220 -17
+ Partials 1267 1261 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Since libp2p/go-libp2p#2560, `0.0.0.0` is no longer valid as a peer connection address. This is causing issues for our tests so we change the IP to `127.0.0.1`.
ebf354e
to
97fdea2
Compare
97fdea2
to
a901e85
Compare
## Relevant issue(s) Resolves sourcenetwork#2043 ## Description This PR updates go dependencies that couldn't be done by dependabot for different reasons. One of which is the result of deprecating `libpeer.ID.Pretty` from `libp2p`. An [update](libp2p/go-libp2p#2560) to `libp2p` also made it no longer valid to connect to a peer on `0.0.0.0`. We now need to use `127.0.0.1` for our tests.
Relevant issue(s)
Resolves #2043
Description
This PR updates go dependencies that couldn't be done by dependabot for different reasons. One of which is the result of deprecating
libpeer.ID.Pretty
fromlibp2p
.An update to
libp2p
also made it no longer valid to connect to a peer on0.0.0.0
. We now need to use127.0.0.1
for our tests.Tasks
How has this been tested?
Make test
Specify the platform(s) on which this was tested: