Skip to content

Encode DataStoreKey FieldID field using encoding package #2818

Open

Description

At the moment the field ids are encoded as string, which takes up more storage space than is required, and may expose us to fetcher bugs in the future similar to #2810 (I'm pretty confident we are safe atm).

It will likely be necessary to remove the current "C" field ID before doing so, as the binary encoded uint32 values will clash with "C" and otherwise make encoding/decoding harder than it needs to be. "C" isn't even really used anymore, its just the DataStoreKey is misused as HeadStoreKey in someplaces, which does still use "C".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    area/datastoreRelated to the datastore / storage engine systembugSomething isn't workingcode qualityRelated to improving code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions