Skip to content

graphql-go package relies on mutable state defined in init #2782

Open

Description

The graphql-go package relies on mutable state defined in init in https://github.com/graphql-go/graphql/blob/master/introspection.go - this means that multiple Defra instances created in the same process share state.

Although it has not yet been known to create issues in production, it is not wonderful, and prevents us from parallelizing the Defra tests using t.Parallel() alongside the --race flag.

I suggest we resolve this by removing the graphql-go dependency, probably whilst moving to a DQL=>GQL transpiler system instead of the SDL parsing stuff we currently rely on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    area/queryRelated to the query componentbugSomething isn't workingcode qualityRelated to improving code quality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions