Skip to content

Improve indexing logs around absolute paths#682

Merged
jviotti merged 1 commit intomainfrom
relative-display-paths
Feb 26, 2026
Merged

Improve indexing logs around absolute paths#682
jviotti merged 1 commit intomainfrom
relative-display-paths

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 26, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@augmentcode
Copy link

augmentcode bot commented Feb 26, 2026

🤖 Augment PR Summary

Summary: Improves indexing progress output by avoiding absolute filesystem paths in log messages.

Changes:

  • Introduces display-only paths for schemas, explorer, and routes.bin using std::filesystem::relative against the output directory.
  • Uses these display paths in print_progress and DISPATCH skip/progress logging while keeping the actual output targets unchanged.
  • Updates CLI golden tests to expect the shorter, relative log paths.

Technical Notes: This should be a logging-only change; generation still uses the original absolute/fully-qualified paths for filesystem operations.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 9643732 into main Feb 26, 2026
6 checks passed
@jviotti jviotti deleted the relative-display-paths branch February 26, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant