Reset inodes on index writes to better support hard links#679
Merged
Conversation
🤖 Augment PR SummarySummary: This PR updates index/build output writes to recreate files instead of truncating them in-place. Changes:
Technical Notes: The intent is to avoid hard-link side effects by ensuring rebuilds create new files rather than modifying existing hard-linked inodes. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/index/output.h">
<violation number="1" location="src/index/output.h:91">
P2: Unconditionally removing the file before opening the stream can delete the existing file if the open fails, causing data loss on error paths (and in release builds the assert doesn’t guard against a bad stream). Consider a safer write strategy that preserves the old file until the new write succeeds.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
abb5c78 to
935d7b6
Compare
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
935d7b6 to
72b26c2
Compare
ea98159 to
1544a77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com