Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Dec 30, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Dec 30, 2025

🤖 Augment PR Summary

Summary: This PR removes instance-location reporting from the inspect CLI output.

Changes:

  • Drops printing of Instance Location lines and removes the instances section from inspect's JSON output.
  • Switches inspect framing to SchemaFrame::Mode::References (no longer computing instance data).
  • Updates the vendored sourcemeta/core dependency and removes instance-location tracking from SchemaFrame and the schema walker iterator entries.
  • Removes JSON Pointer template support from the vendored JSON Pointer API (and related hashing/stringify helpers).
  • Updates alter-schema rules to preserve branch order while deduplicating allOf/anyOf, and adds reference re-mapping hooks for transformations.
  • Adjusts inspect CLI golden tests to match the new output format.

Technical Notes: The core framing code now focuses on locations/references only, reducing compute/memory previously used to derive unresolved instance locations.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.


// Skip entries that have direct references pointing to them
const auto entry_pointer{
location.relative_pointer.concat({"allOf", index - 1})};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SchemaFrame::references_to() compares against Location.pointer (root pointer), but this check builds entry_pointer from location.relative_pointer. If the schema has nested $id/base changes, relative_pointer can differ from the root pointer and this may miss existing references to an allOf branch, allowing an unsafe elevation.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

@jviotti jviotti merged commit abf2ee3 into main Dec 30, 2025
12 checks passed
@jviotti jviotti deleted the core-94 branch December 30, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants