[Linter]: create rule that adds missing hash to metaschema uri's of drafts before 2019-09 #1823
Conversation
…a uri's of drafts before 2019-09 Signed-off-by: karan-palan <karanpalan007@gmail.com>
|
@jviotti , PTAL I haven't used the |
| } | ||
|
|
||
| const auto schema_value = schema.at("$schema").to_string(); | ||
| return !schema_value.empty() && schema_value.back() != '#' && |
There was a problem hiding this comment.
I don't think you need these first two checks. Just checking schema_value against the possibilities afterwards is enough?
| return false; | ||
| } | ||
|
|
||
| const auto schema_value = schema.at("$schema").to_string(); |
There was a problem hiding this comment.
| const auto schema_value = schema.at("$schema").to_string(); | |
| const auto &schema_value{schema.at("$schema").to_string()}; |
Otherwise you are unnecessarily copying the string
| auto transform(sourcemeta::core::JSON &schema) const -> void override { | ||
| auto schema_value = schema.at("$schema").to_string(); | ||
| schema_value += "#"; | ||
| schema.at("$schema").into(sourcemeta::core::JSON{schema_value}); |
There was a problem hiding this comment.
| schema.at("$schema").into(sourcemeta::core::JSON{schema_value}); | |
| schema.at("$schema").into(sourcemeta::core::JSON{std::move(schema_value)}); |
To avoid yet another copy
| class MetaschemaUriMissingHash final : public SchemaTransformRule { | ||
| public: | ||
| MetaschemaUriMissingHash() | ||
| : SchemaTransformRule{"metaschema_uri_missing_hash", |
There was a problem hiding this comment.
Can we call the id draft_official_dialect_without_empty_fragment? In particular, "hash" is not the correct term. In URI parlance, it is an empty fragment
There was a problem hiding this comment.
Then for the other rule where we remove the empty fragment in 2019-09 and 2020-12 we can call it modern_official_dialect_with_empty_fragment?
There was a problem hiding this comment.
Sounds good, will update those in the rule repo as well
| public: | ||
| MetaschemaUriMissingHash() | ||
| : SchemaTransformRule{"metaschema_uri_missing_hash", | ||
| "The canonical metaschema URIs end with `schema#`. " |
There was a problem hiding this comment.
Maybe simplify it like this:
The official dialect URI of Draft 7 and older versions must contain the empty fragment
…hema-uri-missing-hash
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
…hema-uri-missing-hash
|
@jviotti , resolved the merge conflicts. PTAL |
No description provided.