ClangTidy warnings for `performance-enum-size`

[jviotti]

/Users/jviotti/Projects/core/src/core/json/include/sourcemeta/core/json_value.h:48:14: error: enum 'ParsePhase' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   48 |   enum class ParsePhase { Pre, Post };
      |              ^

/Users/jviotti/Projects/core/src/core/json/include/sourcemeta/core/json_value.h:51:14: error: enum 'Type' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   51 |   enum class Type : std::uint8_t {
      |              ^

/Users/jviotti/Projects/core/src/core/jsonpointer/include/sourcemeta/core/jsonpointer_template.h:19:14: error: enum 'Wildcard' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   19 |   enum class Wildcard { Property, Item, Key };
      |              ^

/Users/jviotti/Projects/core/src/core/jsonschema/frame.cc:13:12: error: enum 'AnchorType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   13 | enum class AnchorType : std::uint8_t { Static, Dynamic, All };
      |            ^

/Users/jviotti/Projects/core/src/core/jsonschema/include/sourcemeta/core/jsonschema_frame.h:109:14: error: enum 'Mode' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  109 |   enum class Mode { Locations, References, Instances };
      |              ^

/Users/jviotti/Projects/core/src/core/jsonschema/include/sourcemeta/core/jsonschema_frame.h:144:14: error: enum 'LocationType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
  144 |   enum class LocationType : std::uint8_t {
      |              ^

/Users/jviotti/Projects/core/src/core/jsonschema/include/sourcemeta/core/jsonschema_types.h:41:12: error: enum 'SchemaIdentificationStrategy' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   41 | enum class SchemaIdentificationStrategy : std::uint8_t {
      |            ^

/Users/jviotti/Projects/core/src/core/jsonschema/include/sourcemeta/core/jsonschema_types.h:51:12: error: enum 'SchemaReferenceType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   51 | enum class SchemaReferenceType : std::uint8_t { Static, Dynamic };
      |            ^

/Users/jviotti/Projects/core/src/core/jsonschema/include/sourcemeta/core/jsonschema_types.h:62:12: error: enum 'SchemaKeywordType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   62 | enum class SchemaKeywordType : std::uint8_t {
      |            ^

/Users/jviotti/Projects/core/src/core/jsonschema/walker.cc:7:12: error: enum 'SchemaWalkerType_t' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
    7 | enum class SchemaWalkerType_t : std::uint8_t { Deep, Flat };
      |            ^

/Users/jviotti/Projects/core/src/core/regex/include/sourcemeta/core/regex.h:70:12: error: enum 'RegexIndex' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   70 | enum class RegexIndex : std::uint8_t {
      |            ^

/Users/jviotti/Projects/core/src/extension/alterschema/include/sourcemeta/core/alterschema.h:25:12: error: enum 'AlterSchemaCategory' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   25 | enum class AlterSchemaCategory {
      |            ^

[bavulapati]

These are not reported anymore.

[jviotti]

They are for me. Could be the ClangTidy version. On my machine, I still get them through LLVM 19.1.7 (Homebrew)

[bavulapati]

They are for me. Could be the ClangTidy version. On my machine, I still get them through LLVM 19.1.7 (Homebrew)

I'm using clang 18 on Linux.

[bavulapati]

clang-tidy-19 also doesn't report these errors

[jviotti]

Yeah, no idea. I guess let's make the one in GitHub Actions pass and just worry about what that reports for now?

[bavulapati]

/Users/jviotti/Projects/core/src/core/jsonschema/frame.cc:13:12: error: enum 'AnchorType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
   13 | enum class AnchorType : std::uint8_t { Static, Dynamic, All };
      |            ^
/Users/jviotti/Projects/core/src/core/jsonschema/walker.cc:7:12: error: enum 'SchemaWalkerType_t' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size,-warnings-as-errors]
    7 | enum class SchemaWalkerType_t : std::uint8_t { Deep, Flat };
      |            ^

These are the two reported on my mac.
But if we se the warning doesn't make sense as it is suggesting already existing usage of std::uint8_t

Let me know if I'm reading it wrong.

[jviotti]

Yeah, the warning seems off in some cases. Could it be because those files don't directly pull <cstdint> and thus ClangTidy gets confused? (just brainstorming). In any case, given other issues, either ClangTidy tends to be a bit weird or the way I set it up is wrong? Not sure

[bavulapati]

I tried including and it's not about it.

[jviotti]

Yeah, not sure. ClangTidy seems weird, or otherwise we are doing something wrong. I'll continue researching on the side