Adding adoption by NASA #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
jviotti
reviewed
May 9, 2024
jviotti
reviewed
May 9, 2024
jviotti
requested changes
May 9, 2024
Member
jviotti
left a comment
jviotti
left a comment
There was a problem hiding this comment.
I left some comments. Also, I think you forgot to run npm start as said on the contributing guide. Otherwise the README won't be re-generated
Signed-off-by: Suprith KG <suprith7kg@gmail.com> a
Contributor
Author
Oh! I just pushed the yaml file. Guideline said - add directly to yaml and send a PR.. . |
Member
|
Feel free to clarify the contributing guide in another PR if you want! |
Contributor
Author
|
Member
|
Something like that. If you send a PR, I can drop suggestions there |
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.