Don't lint $ref siblings for default/examples in Draft 7 and older#609
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Don't lint $ref siblings for default/examples in Draft 7 and older#609staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect $ref sibling semantics for default/examples by draft
Summary
This PR makes the
ValidDefaultandValidExampleslinter rules draft-aware when the keyword appears as a sibling of$ref.What changed
In Draft 7 and older, if a schema object contains both
$refand:default(forValidDefault), orexamples(forValidExamples)the rule now skips linting/transforming that object (because siblings of
$refmust be ignored in those drafts).In 2019-09 and 2020-12, the rules continue to lint those siblings and will still remove invalid
default/examplesvalues.Tests added
For both
valid_defaultandvalid_examples, new tests cover:Local verification
make configure compilemake(including tests); passedReview & Testing Checklist for Human
vocabularies(meta-data vocab presence) is the right signal for distinguishing 2019-09+/2020-12 from Draft-07/06/04 in all linter execution paths.ValidDefault::conditionandValidExamples::conditionto ensure the scope is correct (only$refsibling cases, no unintended skips).blaze.lintertests (or fullmake) and verify the new draft-specific cases match expected JSON Schema semantics end-to-end.Notes
$refsibling handling in older drafts for shipped lint rules.