Fix SimpleOutput annotation pruning for contains failures#607
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Fix SimpleOutput annotation pruning for contains failures#607staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SimpleOutput pruning of annotations in failing contains items
Summary
This PR fixes a
SimpleOutputannotation collection bug where annotations produced while evaluating acontainssubschema were retained for array items that failed thecontainssubschema.What changed
SimpleOutputnow prunes annotations using both:instead of evaluate path alone.
contains(which are intentionally not emitted as output errors),SimpleOutputnow still performs annotation cleanup onPostfailure events before returning.containswith nestedtitle["foo", 42, true]/1(the matching item) and dropped for/0and/2.Review & Testing Checklist for Human
evaluate_path+instance_location) does not accidentally preserve/drop annotations in non-containsfailure cases (especially nested schemas and sibling annotation keywords).containscontrol flow change is correct: failures remain suppressed in output, but annotations from failing items are removed.contains+title+ mixed array) and confirm only the matching item retains thetitleannotation in verbose output.Notes
make configure compileandmake(test suite passed).