Reuse ValueIndexPair definition when declaring ValueStringHashes#604
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Reuse ValueIndexPair definition when declaring ValueStringHashes#604staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
ValueIndexPair definition when declaring ValueStringHashes#604staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse
ValueIndexPairdefinition when declaringValueStringHashesSummary
ValueStringHasheswas declaring its second element asstd::vector<std::pair<std::size_t, std::size_t>>, which is exactly whatValueIndexPairalready defines (line 107 of the same file). This PR replaces the redundant inline type with the existingValueIndexPairalias.The resolved type is identical — this is a zero-behavior-change refactor.
Review & Testing Checklist for Human
ValueIndexPair(defined asstd::pair<std::size_t, std::size_t>on line 107) is indeed the correct semantic match for the second vector element inValueStringHashesNotes
make configure compile; no formatting diffs remain aftermake