Skip to content

Reuse ValueIndexPair definition when declaring ValueStringHashes#604

Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
evalon/blaze-reus-4cadc198
Open

Reuse ValueIndexPair definition when declaring ValueStringHashes#604
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
evalon/blaze-reus-4cadc198

Conversation

@staging-devin-ai-integration
Copy link

Reuse ValueIndexPair definition when declaring ValueStringHashes

Summary

ValueStringHashes was declaring its second element as std::vector<std::pair<std::size_t, std::size_t>>, which is exactly what ValueIndexPair already defines (line 107 of the same file). This PR replaces the redundant inline type with the existing ValueIndexPair alias.

The resolved type is identical — this is a zero-behavior-change refactor.

Review & Testing Checklist for Human

  • Confirm that ValueIndexPair (defined as std::pair<std::size_t, std::size_t> on line 107) is indeed the correct semantic match for the second vector element in ValueStringHashes

Notes

  • Build passes cleanly with make configure compile; no formatting diffs remain after make
  • Requested by: bot_apk
  • Devin Session

Co-Authored-By: bot_apk <apk@cognition.ai>
@staging-devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants