Don't lint $ref siblings for default/examples in Draft 7 and older#603
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Don't lint $ref siblings for default/examples in Draft 7 and older#603staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip
default/examples$refsiblings in Draft 7 and olderSummary
This PR updates the
ValidDefaultandValidExampleslinter rules to respect JSON Schema draft semantics for$refsiblings:$ref, the linter now skips lintingdefault/examplessiblings (they must be ignored by implementations).default/examplessiblings to$refare still detected and removed.It also adds regression tests for both rules covering:
$refsibling preservation$refsibling removal$refsibling removalReview & Testing Checklist for Human
ValidDefault::conditionandValidExamples::conditionmatches intended draft behavior (especially howvocabulariesare populated).$refsiblings.Recommended test plan:
make configure compilemake{ "$ref": ..., "default": ... }and{ "$ref": ..., "examples": [...] }in Draft-07 vs 2019-09/2020-12Notes
make configure compile && make(passed)