Fix SimpleOutput annotation cleanup for failing contains items#602
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Fix SimpleOutput annotation cleanup for failing contains items#602staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SimpleOutput cleanup for failing contains item annotations
Summary
This PR fixes a
SimpleOutputannotation retention bug forcontainssubschema failures.Previously, when a
containsitem failed (and the failure was masked from output),SimpleOutputcould keep annotations (e.g.title) for that failing item because cleanup was skipped before the early return. The fix adds targeted cleanup for maskedcontainsfailures and scopes that cleanup using both:so annotations from failing items are dropped without removing valid annotations from matching items or the root
containsannotation.Also adds a regression test for:
contains: { "type": "number", "title": "Test" }[ "foo", 42, true ]and verifies only the root
/containsannotation and the/1titleannotation remain.Review & Testing Checklist for Human
SimpleOutputis correct forcontainsand does not unintentionally change behavior for other masked keywords (anyOf/oneOf/not/if).starts_with_initial+size()+instance_location.starts_with(...)combination to confirm it removes only sibling annotations for the failing item, not parent/root annotations./0and/2are no longer emitted while/1is retained.Recommended human test plan:
compiler_output_simpletests.--verbose.containsannotation case (includingunevaluatedItemsinteractions) to ensure no regressions.Notes
make configure compileandmake(passed).