Support instancePosition in standard output#598
Open
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Support instancePosition in standard output#598staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
staging-devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instancePosition support to standard output with pointer tracker
Summary
This PR extends
sourcemeta::blaze::standardwith a new overload that accepts asourcemeta::core::PointerPositionTracker.When the tracker is provided (Basic output mode), emitted error and annotation units are augmented with an
instancePositionproperty containing line/column bounds as:[ lineStart, columnStart, lineEnd, columnEnd ]Implementation notes:
standard(...)behavior/signature is preserved and now delegates internally.instancePositionis only added when a tracker lookup exists for the unit'sinstanceLocation.instancePositioninstancePositionReview & Testing Checklist for Human
instance, tracker, format) matches the intended public API and downstream usage expectations.instancePositionvalues (especially line/column indexing semantics) against expectedPointerPositionTrackerconventions for a few sample payloads, including nested objects/arrays if relevant.Recommended human test plan:
PointerPositionTrackerand call the newstandard(...)overload inBasicmode.errors[*].instancePositionandannotations[*].instancePositionexist and map to the tracked pointer positions.instancePositionfields).Notes
make configure compile && make(passes).