Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranking: remove document ranks #853

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

stefanhengl
Copy link
Member

@stefanhengl stefanhengl commented Oct 30, 2024

Document ranks was an experimental feature of Sourcegraph. We have already removed the code in Sourcegraph in the last release. This is the corresponding cleanup for Zoekt.

Test plan:

  • updated tests
  • manual testing: started Sourcegraph locally with this version of Zoekt and checked it compiles and that search and indexing works as expected.

Document ranks was an experimental feature of Sourcegraph. We have
already removed the code in Sourcegraph in the last release. This
is the corresponding cleanup for Zoekt.

Test plan:
updated tests
@cla-bot cla-bot bot added the cla-signed label Oct 30, 2024
@stefanhengl stefanhengl changed the title ranking: removing document ranks ranking: remove document ranks Oct 30, 2024
@stefanhengl stefanhengl requested a review from a team October 30, 2024 12:40
@stefanhengl stefanhengl marked this pull request as ready for review October 30, 2024 15:22
Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. To double-check, this shouldn't cause us to reindex all repos or anything right?

@stefanhengl
Copy link
Member Author

Looks good to me. To double-check, this shouldn't cause us to reindex all repos or anything right?

Yes. I confirmed locally that existing shards can still be read and are not reindexed.

@stefanhengl stefanhengl merged commit c7f1e69 into main Oct 31, 2024
9 checks passed
@stefanhengl stefanhengl deleted the sh/remove-document-ranks branch October 31, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants