add interface for inverted index #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have two implementations, comninedNgramOffset and binarySearchNgram, for the inverted index from ngrams to posting lists. With the btree I am working on, a third implementation will follow soon. The current apporach guarantees a zero-value that won't panic in the tests, however, I don't think we should pile on top of that for the third implementation, but rather handle nil in the code and return an error where it makes sense.
keegancsmith
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have two implementations, combinedNgramOffset and binarySearchNgram, for the inverted index from ngrams to posting lists. With the btree I am working on, a third implementation will follow soon.
The current apporach guarantees a zero-value that won't panic in the tests, however, I don't think we should pile on top of that for the third implementation, but rather handle nil in the code and return an error where it makes sense.