ci: build and push docker images #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
force-pushed
the
core/docker
branch
8 times, most recently
from
788f80c to
430ad49
Compare
Change-Id: I4875b206e91f34a83edcc08e744d3095e337a64a
Purposefully doesn't push so you can see how it behaves on this PR. A follow-up commit will only run this job on the master branch and push. Change-Id: Ifa4b34b943d844e6f9daf9c3ff084793c169c8f3
keegancsmith
force-pushed
the
core/docker
branch
from
430ad49 to
ea8a3af
Compare
Change-Id: I84f43786a9957cb1af17c0dd295c1dae7fa0dbbe
keegancsmith
force-pushed
the
core/docker
branch
from
b815020 to
ad5b521
Compare
keegancsmith
requested review from
mrnugget,
rvantonder,
unknwon,
ggilmore and
ryanslade
|
@ggilmore you may be interested in this, building docker images in github actions. It has quite a nice model. |
unknwon
approved these changes
Mar 21, 2020
There was a problem hiding this comment.
Nice!
qq: Do all these .ctags need to be mirrored whenever we update them in https://sourcegraph.com/github.com/sourcegraph/sourcegraph@2a41e2f265f53a95698b32a1f2f647222a56fec5/-/tree/cmd/symbols/.ctags.d?
yes. In fact I updated them with what we had mirrored in sourcegraph. I plan on improving this situation so we don't rely on mirroring them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port and improvement of our docker images in infrastructure. It will build and push zoekt-webserver and zoekt-indexserver images on every push to master. We use GitHub actions to achieve this. It uses the same version format as we previously did.
The improvement is to share a base image which contains all the zoekt binaries and dependencies. The different images then just copy out what they need and do the sourcegraph specific customizations. This helps us share layers in a cluster as well as reduce the time it takes to build.
See the CI status for ea8a3af to see an example of the docker builds (but with push and branch if disabled).
Fixes https://github.com/sourcegraph/sourcegraph/issues/5819