Skip to content

Conversation

@davejrt
Copy link
Contributor

@davejrt davejrt commented May 5, 2023

Allows us to build src-cli with bazel and subsequently use bazel build in other projects where we use src-cli ie: codeintelQA

Test plan

INFO: Analyzed 45 targets (0 packages loaded, 0 targets configured).
INFO: Found 45 targets...
INFO: Elapsed time: 0.188s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfu

@davejrt davejrt requested review from burmudar and jhchabran May 5, 2023 13:00
@davejrt davejrt enabled auto-merge (squash) May 5, 2023 13:04
Copy link
Contributor

@jhchabran jhchabran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we instead use the binaries as they are released for each platform? https://github.com/sourcegraph/src-cli/releases

@davejrt
Copy link
Contributor Author

davejrt commented May 5, 2023

Can't we instead use the binaries as they are released for each platform? https://github.com/sourcegraph/src-cli/releases

One of the tests builds it from a specific commit, not a release https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/dev/ci/integration/code-intel/install-src.sh

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't build the released versions with bazel yet would it? we use goreleaser for that. Just curious, not a blocker

@davejrt davejrt merged commit f3812db into main May 17, 2023
@davejrt davejrt deleted the dt/bazel branch May 17, 2023 14:58
@davejrt
Copy link
Contributor Author

davejrt commented May 17, 2023

this won't build the released versions with bazel yet would it? we use goreleaser for that. Just curious, not a blocker

Not yet, we're using this so we can build src-cli for other images/tests inside the sourcegraph/sourcegraph code base with bazel instead of go run/go build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants