Adds the src scout utility to the CLI
#978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prints all current resource allocations for each service (CPU, Memory, Storage) to the terminal
- Previously, you could only run `scout` on a k8s deployment - Now, by specifying the `--docker` flag, you can run against a docker deployment - Added unit tests for ResourcesK8s and ResourcesDocker
jasonhawkharris
requested review from
DaedalusG,
abeatrix,
emidoots,
jac and
jdpleiness
jdpleiness
reviewed
May 2, 2023
Contributor
jdpleiness
left a comment
jdpleiness
left a comment
There was a problem hiding this comment.
On first pass this looks good overall. I would revisit the testing setup and whether or not to use mocking or if another approach would work.
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
jdpleiness
reviewed
May 3, 2023
- change package from resources to resource - renamed files accordingly - changed from if statement to switch statement. - deleted empty README.md
jdpleiness
approved these changes
May 15, 2023
Contributor
jdpleiness
left a comment
jdpleiness
left a comment
There was a problem hiding this comment.
Looks like everything as been addressed 🚀
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
src scoututility is a command that helps users manage resources. This PR:scoututility to the CLIresourcesubcommand, which prints resource allocations for all Sourcegraph servicesTest plan
Shipped with unit tests.