feat: introduce -fail-fast flag for src batch #1154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SRCH-1778
Customers want to iterate faster with batch changes, and they need the src cli to fail faster when something goes wrong.
This PR introduces a
-fail-fast
flag and migrates the concurrency inexecutor.go
fromgithub.com/neelance/parallel
togithub.com/sourcegraph/conc
.Test plan
New unit tests
Manual test:
We may be lucky that
gitpod
from the spec is the first task being processed. If the task you're failing on comes last, there may be no speed gain.Spec
go run ./cmd/src batch preview -j 1 spec.yaml
Cleared the cache with
rm -R /Users/michael/Library/Caches/sourcegraph/batch/*
go run ./cmd/src batch preview -fail-fast -j 1 spec.yaml
Cleared the cache with
rm -R /Users/michael/Library/Caches/sourcegraph/batch/*
history -D