Skip to content

fix(Source): Fix broken code host doc links #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mmanela
Copy link
Contributor

@mmanela mmanela commented Jun 14, 2024

Fixes urls to doc pages that do not resolve anymore

Test plan

  • Test new urls are valid

@mmanela mmanela requested a review from a team June 14, 2024 18:50
@mmanela mmanela requested a review from a team as a code owner June 14, 2024 18:50
@mmanela
Copy link
Contributor Author

mmanela commented Jun 14, 2024

@jhchabran After this is fixed we need to get sourcegraph repo to use it so we can re-generate doc/cli/references/serve-git.md. Can you point me to how I do that?

@jhchabran
Copy link
Contributor

jhchabran commented Jun 17, 2024

@mmanela

  1. Need to cut a new release in src-cli
  2. Update SRC_CLI_VERSION
  3. Run sg bazel //doc/cli/references:write_doc_files (the classic approach is to use //dev:write_all_generated but I gave you the specific target that does it so it's faster).
  • It will fail on the first run, complaining about a different checksum for the archive, take the new one and update it in the same file.
  • On the second run it will update the docs.
  1. Commit and open a PR.
  2. Once it lands on main, it will automatically generates a PR toward the docs repo.

@mmanela mmanela merged commit dcc02b2 into main Jun 17, 2024
8 checks passed
@mmanela mmanela deleted the mmanela/fix-broken-doc-links branch June 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants