Skip to content

Conversation

@BolajiOlajide
Copy link
Contributor

@BolajiOlajide BolajiOlajide commented Nov 7, 2023

This upgrades the lib package in src-cli so that it contains the fixes for the fork attribute of non-server-side batch changes.

Test plan

Demo
Tested on my local instance with several spec to be sure we cover all cases.

// Draft Changeset

name: testing-fork-specs-3
description: testing fork for changesets

on: 
  - repository: github.com/sourcegraph-testing/zap

steps:
  - run: IFS=$'\n'; echo "Testing" | tee -a $(find -name README.md)
    container: alpine:3

changesetTemplate:
  title: Hello World
  body: My first batch change!
  commit:
    message: Append Hello World to all README.md files
  branch: ${{ batch_change.name }}
  fork: true
  published: draft
// Published Changeset
name: testing-fork-specs-2
description: testing fork for changesets

on: 
  - repository: github.com/sourcegraph-testing/etcd

steps:
  - run: IFS=$'\n'; echo "Testing" | tee -a $(find -name README.md)
    container: alpine:3

changesetTemplate:
  title: Hello World
  body: My first batch change!
  commit:
    message: Append Hello World to all README.md files
  branch: ${{ batch_change.name }}
  fork: true
  published: true
// Unpublished Changeset
name: testing-fork-specs
description: testing fork for changesets

on: 
  - repository: github.com/sourcegraph-testing/markdowns

steps:
  - run: IFS=$'\n'; echo "Testing" | tee -a $(find -name README.md)
    container: alpine:3

changesetTemplate:
  title: Hello World
  body: My first batch change!
  commit:
    message: Append Hello World to all README.md files
  branch: ${{ batch_change.name }}
  fork: true

bazel-zoekt
bazel-src-cli
.DS_Store
samples
Copy link
Contributor Author

@BolajiOlajide BolajiOlajide Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a directory for adding specs to test with.

@BolajiOlajide BolajiOlajide marked this pull request as ready for review November 8, 2023 10:09
@BolajiOlajide BolajiOlajide requested review from a team, camdencheek and peterguy November 8, 2023 10:10
@BolajiOlajide BolajiOlajide merged commit e12882d into main Nov 8, 2023
@BolajiOlajide BolajiOlajide deleted the bo/bug-fix-changeset-fork branch November 8, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants