Skip to content

batches: File upload error handling #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Piszmog merged 2 commits into from
Aug 7, 2023
Merged

batches: File upload error handling #1015

Piszmog merged 2 commits into from
Aug 7, 2023

Conversation

@Piszmog
Copy link
Contributor

@Piszmog Piszmog commented Aug 7, 2023

Two recent issues were found.

  • When a file exceeded the size limit, the file name was not in the error. This made it hard to tell which file is causing the issue
  • The error being returned was still set after logging as a warn. This made it so the program still errored out

Thread of context.

Test plan

Existing tests cover changes.

Screenshot 2023-08-07 at 13 41 54

peterguy
peterguy approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@peterguy peterguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on err being set

@Piszmog Piszmog merged commit 7c5da8e into main Aug 7, 2023
@Piszmog Piszmog deleted the rc/batches-file-name-error branch August 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterguy peterguy peterguy approved these changes

@BolajiOlajide BolajiOlajide BolajiOlajide approved these changes

@courier-new courier-new Awaiting requested review from courier-new

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piszmog @peterguy @BolajiOlajide