This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: Do not alert on limit errors #47751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efritz
added
team/graph
Strum355
reviewed
Feb 16, 2023
| ErrorFilter: func(err error) observation.ErrorFilterBehaviour { | ||
| if errors.As(err, &inference.LimitError{}) { | ||
| return observation.EmitForDefault.Without(observation.EmitForMetrics) | ||
| return observation.EmitForNone |
There was a problem hiding this comment.
Error log, nah, it's like a 400-level error.
There was a problem hiding this comment.
Or am I misunderstanding this filter?
There was a problem hiding this comment.
User issue (missing resource, bad auth) not server issue (500 level, actual error to report)
There was a problem hiding this comment.
Is it fine to have it silently not do anything in that case? whats the expected method for admins to see why nothing is happening for example (scoping out the thought process here)
There was a problem hiding this comment.
We're also exposing it via the UI here: https://github.com/sourcegraph/sourcegraph/pull/47748.
cesrjimenez
approved these changes
Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put error filters around inference errors.
Test plan
Tested locally, saw less blather.