This repository was archived by the owner on Sep 30, 2024. It is now read-only.
rbac: remove deleted_at from roles column #47411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
courier-new
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Nice, was actually going to ask about this on another PR, but then I saw this one. 🙂
Just an FYI to remind you to remove it here from your other PR, too.
Good catch. Thanks. |
BolajiOlajide
force-pushed
the
bo/remove-roles-deleted_at
branch
from
b3a33d2 to
e880e9d
Compare
BolajiOlajide
added
cla-signed
rbac
batch-changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the
deleted_atcolumn (now looking at it in hindsight) was an oversight. It complicates the logic for the MVP a bit. Since site admins can create and delete roles, it's easy to remove that column and expect that if a role is deleted, it can be made and reassigned to whatever users were assigned to it before.Test plan