This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: clean up pagination related code #47369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashaostrikov
added
the
permissions-center
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 8c63877...96d772a. No notifications. |
sashaostrikov
force-pushed
the
ao/chore/cleanup-pagination-code
branch
from
397dec5 to
3d928f8
Compare
Test plan: CI.
sashaostrikov
force-pushed
the
ao/chore/cleanup-pagination-code
branch
from
3d928f8 to
96d772a
Compare
sashaostrikov
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, passing more than one OrderBy parameters and using After/Before constructed invalid SQL queries such as:
WHERE (user_id, repository_id) < (1).The fix won't let this situation happen and keep only the first column for WHERE clause.
Test plan:
Test added + CI.
Test plan