This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: allow to save the default number of series samples #47329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 2, 2023 14:40
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e2ede87...f776219.
|
chwarwick
approved these changes
Feb 7, 2023
enterprise/cmd/frontend/internal/insights/resolvers/insight_view_resolvers.go
Outdated
Show resolved
Hide resolved
enterprise/cmd/frontend/internal/insights/resolvers/insight_series_resolver.go
Outdated
Show resolved
Hide resolved
…ew_resolvers.go Co-authored-by: Chris Warwick <christopher.warwick@sourcegraph.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46283
Test plan
Added store unit test. Added integration test
Manually tested:
Screen.Recording.2023-02-02.at.17.09.04.mov