GraphQL code intel doesn't work

[felixfbecker]

I have the GraphQL extension enabled, and with https://github.com/sourcegraph/sourcegraph/pull/8099 and sourcegraph/code-intel-extensions#206 my understanding is that GraphQL schema files like https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/cmd/frontend/graphqlbackend/schema.graphql#L541:12 (latest master) should have code intel.

But there are no symbols found in the symbols sidebar, and no hovers for types from the schema - instead, I do get hovers that point to same-name symbols found in Go code:

The symbols query comes back empty:

It seems like then the codeintel extension falls back to searching the whole repo, but it doesn't filter it to only GraphQL files (I could see why this may be desirable, but am curious if this is as-designed).

Now, what's weird is that on some commits, I do get symbols and also same-file hovers:

https://sourcegraph.com/github.com/sourcegraph/sourcegraph@133f9631a97f991328048f455f69b62cb38a9c16/-/blob/cmd/frontend/graphqlbackend/schema.graphql#L541:12

Also, the extension page of the GraphQL page seems to show screenshots of Python code?

[felixfbecker]

One difference I noticed: When symbols do show up, the GraphQL query had the commit hash passed as the rev. But in the request above where it did't work (whenever I'm on latest master with no explicit rev in the URL), rev is an empty string, and no symbols are returned by the backend. Maybe the latest revision uses indexed search, and explicit revs (even if they match latest master) use non-indexed search, and indexed symbol search seems to be broken (on files at least).

[efritz]

Do you see similar behaviors for non-GraphQL files?

[felixfbecker]

I don't really see basic code intel in action a lot since TS and Go have precise code intel, so I unfortunately can't confirm if other languages are affected, but not unlikely that this affects all languages seeing that the symbols sidebar is affected as well

[felixfbecker]

FYI I fixed syntax highlighting in #10043

[efritz]

@felixfbecker can you confirm this is still an issue? I couldn't reproduce recently.

[felixfbecker]

I can reproduce it with the link in the issue description:

[efritz]

I don't know what I was doing earlier. Description in the issue is great.

It looks like there are no symbols for GraphQL if the commit is indexed. If I comment out the call to searchZoektSymbols in the git commit resolver this pane populates. I'm not sure how ctags and zoekt interoperate.

I think @keegancsmith may have some additional context to add here.