Use Gradle project path for unique dependencies.txt path#741
Merged
antonsviridov-src merged 1 commit intomainfrom Aug 20, 2024
Merged
Use Gradle project path for unique dependencies.txt path#741antonsviridov-src merged 1 commit intomainfrom
antonsviridov-src merged 1 commit intomainfrom
Conversation
olafurpg
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The javadoc on
Project#getNamementions that name is not guaranteed to be unique across the hierarchy, but project path is. So ew use this to write the dependencies to uniquely named files.See https://github.com/sourcegraph/scip-java/pull/735/files#diff-5dde761886519812960f89108a21668cf947ddb300db91872dafc880f9bd3943R81 where we do the same for Maven.
Test plan