Bazel: fallback to default absolute path logic #620
Merged
Conversation
Previously, we failed compilation when failing to infer the absolute path of a file that was being compiled by Bazel. This commit changes the behavior to fallback to the default behavior, which uses the standard `JavaFileObject.toUri()` API. The goal of this change is to fix an issue that happened when using errorprone together with semanticdb-javac, and errorprone triggers compilation with custom compilation unit here https://sourcegraph.com/github.com/google/error-prone@77ba705df2c213eddd5652622336f4a8fef3c387/-/blob/check_api/src/main/java/com/google/errorprone/fixes/SuggestedFixes.java
olafurpg
force-pushed
the
olafurpg/java-file-object
branch
from
22375e5 to
92b6e9b
Compare
keynmol
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we failed compilation when failing to infer the absolute
path of a file that was being compiled by Bazel. This commit changes the
behavior to fallback to the default behavior, which uses the standard
JavaFileObject.toUri()API. The goal of this change is to fix an issuethat happened when using errorprone together with semanticdb-javac, and
errorprone triggers compilation with custom compilation unit here
https://sourcegraph.com/github.com/google/error-prone@77ba705df2c213eddd5652622336f4a8fef3c387/-/blob/check_api/src/main/java/com/google/errorprone/fixes/SuggestedFixes.java
Test plan
Green CI.