Skip to content

If any errors were reported, fail BazelBuildTool with code 1 #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olafurpg merged 2 commits into from
Jul 6, 2023
Merged

If any errors were reported, fail BazelBuildTool with code 1 #607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a197d58
If any errors were reported, fail BazelBuildTool with code 1
keynmol Jul 6, 2023
42f8636
chore: formatting
keynmol Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions scip-semanticdb/src/main/java/com/sourcegraph/scip_semanticdb/BazelBuildTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,33 @@ public static int runAndReturnExitCode(String[] args) throws IOException, Interr
}

List<MavenPackage> mavenPackages = mavenPackages(options);
ScipSemanticdbReporter reporter =
new ScipSemanticdbReporter() {
private boolean hasErrors = false;

@Override
public void error(Throwable e) {
e.printStackTrace(System.err);
hasErrors = true;
}

@Override
public void error(String message) {
System.err.println("ERROR[scip-semanticdb]: " + message);
hasErrors = true;
}

@Override
public boolean hasErrors() {
return this.hasErrors;
}
};
ScipSemanticdbOptions scipOptions =
new ScipSemanticdbOptions(
options.targetroots,
options.output,
options.sourceroot,
new ScipSemanticdbReporter() {
@Override
public void error(Throwable e) {
e.printStackTrace(System.err);
}
},
reporter,
LsifToolInfo.newBuilder().setName("scip-java").setVersion("HEAD").build(),
"java",
ScipOutputFormat.TYPED_PROTOBUF,
Expand All @@ -50,10 +66,14 @@ public void error(Throwable e) {
"",
true);
ScipSemanticdb.run(scipOptions);

if (!scipOptions.reporter.hasErrors()) {
System.out.println("done: " + scipOptions.output);
return 0;
} else {
System.out.println("SCIP index generation failed");
return 1;
}
return 0;
}

public static List<MavenPackage> mavenPackages(BazelOptions options)
Expand Down